lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next] thermal/drivers/thermal_hwmon: Fix a kernel NULL pointer dereference
    Date
    When the hwmon device node of a thermal zone device is not found,
    using hwmon->device causes a kernel NULL pointer dereference.

    Reported-by: Preble Adam C <adam.c.preble@intel.com>
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>
    ---
    Fixes: dec07d399cc8 ("thermal: Don't use 'device' internal thermal zone structure field")
    dec07d399cc8 is a commit in the linux-next branch of linux-pm repo.
    I'm not sure if the Fix tag applies to such commit or not.
    ---
    drivers/thermal/thermal_hwmon.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
    index c59db17dddd6..261743f461be 100644
    --- a/drivers/thermal/thermal_hwmon.c
    +++ b/drivers/thermal/thermal_hwmon.c
    @@ -229,7 +229,7 @@ void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz)
    hwmon = thermal_hwmon_lookup_by_type(tz);
    if (unlikely(!hwmon)) {
    /* Should never happen... */
    - dev_dbg(hwmon->device, "hwmon device lookup failed!\n");
    + dev_dbg(&tz->device, "hwmon device lookup failed!\n");
    return;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2023-03-29 11:03    [W:4.258 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site