Messages in this thread | | | Date | Wed, 29 Mar 2023 12:53:33 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v8 0/4] convert read_kcore(), vread() to use iterators |
| |
On 03/23/23 at 10:15am, Lorenzo Stoakes wrote: > While reviewing Baoquan's recent changes to permit vread() access to > vm_map_ram regions of vmalloc allocations, Willy pointed out [1] that it > would be nice to refactor vread() as a whole, since its only user is > read_kcore() and the existing form of vread() necessitates the use of a > bounce buffer. > > This patch series does exactly that, as well as adjusting how we read the > kernel text section to avoid the use of a bounce buffer in this case as > well. > > This has been tested against the test case which motivated Baoquan's > changes in the first place [2] which continues to function correctly, as do > the vmalloc self tests. > > [1] https://lore.kernel.org/all/Y8WfDSRkc%2FOHP3oD@casper.infradead.org/ > [2] https://lore.kernel.org/all/87ilk6gos2.fsf@oracle.com/T/#u
The whole series looks good to me.
Reviewed-by: Baoquan He <bhe@redhat.com>
| |