Messages in this thread | | | From | Lukas Bulwahn <> | Date | Wed, 29 Mar 2023 09:55:45 +0200 | Subject | Re: [RFC PATCH] usb: move config USB_USS720 to usb's misc Kconfig |
| |
On Wed, Mar 29, 2023 at 9:39 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Wed, Mar 29, 2023 at 09:17:24AM +0200, Lukas Bulwahn wrote: > > The USS720 parport driver source code is in drivers/usb/misc/, the > > corresponding config is defined in drivers/usb/Kconfig. Some digging in the > > kernel's history revealed no good reason why it needs to be defined in > > USB's top-level Kconfig file, and why the config for the USS720 parport > > driver should be the first in the list of USB port drivers, while all other > > configs for drivers in drivers/usb/misc are in the USB Miscellaneous driver > > configuration file. > > It is that way because this was one of the first USB drivers we had, and > we only had one Kconfig file at the time and no misc/ subdir in the usb > directory. > > So it's just inertia, that's all. > > Your change looks great to me, want to resend it without the RFC so that > I can apply it?
Thanks for the quick response and confirmation, Greg.
You will find the patch without RFC in your mailbox and on lore.kernel.org at:
https://lore.kernel.org/lkml/20230329075125.32352-1-lukas.bulwahn@gmail.com/
Best regards,
Lukas
| |