Messages in this thread | | | Subject | Re: [PATCH v4 0/2] spi: loongson: add bus driver for the loongson spi | From | zhuyinbo <> | Date | Thu, 30 Mar 2023 11:46:34 +0800 |
| |
在 2023/3/29 下午4:07, Krzysztof Kozlowski 写道: > On 28/03/2023 13:53, zhuyinbo wrote: >> >> >> 在 2023/3/28 下午7:35, Andi Shyti 写道: >>> Hi Yinbo, >>> >>> before submitting the patches for review... can you please run >>> checkpatch.pl on them? >> yes, I had used checkpatch.pl to check and no any errors and warnings. >> >> user@user-pc:~/workspace/test/code/www.kernel.org/linux$ >> ./scripts/checkpatch.pl *.patch >> ----------------------- >> 0000-cover-letter.patch >> ----------------------- >> total: 0 errors, 0 warnings, 0 lines checked >> >> 0000-cover-letter.patch has no obvious style problems and is ready for >> submission. >> ------------------------------------------- >> 0001-dt-bindings-spi-add-loongson-spi.patch >> ------------------------------------------- >> Traceback (most recent call last): >> File "scripts/spdxcheck.py", line 6, in <module> >> from ply import lex, yacc >> ModuleNotFoundError: No module named 'ply' >> total: 0 errors, 0 warnings, 55 lines checked >> >> 0001-dt-bindings-spi-add-loongson-spi.patch has no obvious style >> problems and is ready for submission. >> --------------------------------------------------------------- >> 0002-spi-loongson-add-bus-driver-for-the-loongson-spi-con.patch >> --------------------------------------------------------------- >> Traceback (most recent call last): >> File "scripts/spdxcheck.py", line 6, in <module> >> from ply import lex, yacc >> ModuleNotFoundError: No module named 'ply' >> Traceback (most recent call last): >> File "scripts/spdxcheck.py", line 6, in <module> >> from ply import lex, yacc >> ModuleNotFoundError: No module named 'ply' >> Traceback (most recent call last): >> File "scripts/spdxcheck.py", line 6, in <module> >> from ply import lex, yacc >> ModuleNotFoundError: No module named 'ply' >> Traceback (most recent call last): >> File "scripts/spdxcheck.py", line 6, in <module> >> from ply import lex, yacc >> ModuleNotFoundError: No module named 'ply' > > You have errors here... Fix your setup for spdx check. I installed ply and gitpython package locally, and then there was no spdxcheck and other error when use checkpatch.pl to check this series patch.
Thanks. > > Best regards, > Krzysztof >
| |