lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler
    On Tue, Mar 28, 2023 at 06:17:11PM +0200, Pankaj Raghav wrote:
    > >> if (!parent)
    > >> - bio->bi_end_io = zram_page_end_io;
    > >> + bio->bi_end_io = zram_read_end_io;
    > >
    > > Can we just do:
    > >
    > > if (!parent)
    > > bio->bi_end_io = bio_put;
    > >
    >
    > Looks neat. I will wait for Christoph to comment whether just a bio_put() call
    > is enough in this case for non-chained bios before making this change for the
    > next version.

    It is enough in the sense of keeping the previous behavior there.
    It is not enough in the sense that the code is still broken as the
    callers is never notified of the read completion. So I think for the
    purpose of your series we're fine and can go ahead with this version
    for now.

    >
    > Thanks.
    ---end quoted text---

    \
     
     \ /
      Last update: 2023-03-30 01:53    [W:2.055 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site