lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/5] Remove acpi.h implicit include of of.h
Date


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Wednesday, March 29, 2023 2:21 PM
> To: Rafael J. Wysocki <rafael@kernel.org>; Len Brown <lenb@kernel.org>;
> Marcelo Schmitt <marcelo.schmitt1@gmail.com>; Lars-Peter Clausen
> <lars@metafoo.de>; Michael Hennerich <Michael.Hennerich@analog.com>;
> Jonathan Cameron <jic23@kernel.org>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Johannes Berg <johannes@sipsolutions.net>;
> David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Jiri Slaby <jirislaby@kernel.org>; Thierry Reding
> <thierry.reding@gmail.com>; Jonathan Hunter <jonathanh@nvidia.com>; Marc
> Zyngier <maz@kernel.org>
> Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> staging@lists.linux.dev; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-serial@vger.kernel.org; linux-
> tegra@vger.kernel.org; linux-acpi@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [PATCH 0/5] Remove acpi.h implicit include of of.h
>
> In the process of cleaning up DT includes, I found that some drivers
> using DT functions could build without any explicit DT include. I traced
> the include to be coming from acpi.h via irqdomain.h.
>
> I was pleasantly surprised that there were not 100s or even 10s of
> warnings when breaking the include chain. So here's the resulting
> series.
>
> I'd suggest Rafael take the whole series. Alternatively,the fixes can be
> applied in 6.4 and then the last patch either after rc1 or the
> following cycle.
>

Nice that there aren't too many errors. Use of the forward declarations makes sense rather than including a bunch of unrelated definitions. Nice.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks,
Jake

> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Rob Herring (5):
> iio: adc: ad7292: Add explicit include for of.h
> staging: iio: resolver: ad2s1210: Add explicit include for of.h
> net: rfkill-gpio: Add explicit include for of.h
> serial: 8250_tegra: Add explicit include for of.h
> ACPI: Replace irqdomain.h include with struct declarations
>
> drivers/iio/adc/ad7292.c | 1 +
> drivers/staging/iio/resolver/ad2s1210.c | 1 +
> drivers/tty/serial/8250/8250_tegra.c | 1 +
> include/linux/acpi.h | 4 +++-
> net/rfkill/rfkill-gpio.c | 1 +
> 5 files changed, 7 insertions(+), 1 deletion(-)
> ---
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> change-id: 20230329-acpi-header-cleanup-665331828436
>
> Best regards,
> --
> Rob Herring <robh@kernel.org>

\
 
 \ /
  Last update: 2023-03-30 01:24    [W:6.773 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site