Messages in this thread | | | From | "Yang, WenYou" <> | Subject | RE: [PATCH v3 1/2] cpu/smt: add a notifier to notify the SMT changes | Date | Wed, 29 Mar 2023 07:23:29 +0000 |
| |
[AMD Official Use Only - General]
Hi Peter,
Thank you for your review.
The purpose of the patch set is to improve the performance when playing game for some AMD APUs with SMT enabled/disabled.
When change the SMT state on the fly through " echo on/off > /sys/devices/system/cpu/smt/control", the kernel needs to send a message to notify PMFW to adjust a variable's value, which impacts the performance.
Best Regards, Wenyou
> -----Original Message----- > From: Peter Zijlstra <peterz@infradead.org> > Sent: Wednesday, March 29, 2023 3:10 PM > To: Yang, WenYou <WenYou.Yang@amd.com> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian > <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Quan, Evan > <Evan.Quan@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>; > bp@suse.de; jpoimboe@kernel.org; Phillips, Kim <kim.phillips@amd.com>; > tglx@linutronix.de; Yuan, Perry <Perry.Yuan@amd.com>; Liang, Richard qi > <Richardqi.Liang@amd.com>; Li, Ying <YING.LI@amd.com>; Liu, Kun > <Kun.Liu2@amd.com>; gpiccoli@igalia.com; amd-gfx@lists.freedesktop.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 1/2] cpu/smt: add a notifier to notify the SMT changes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Wed, Mar 29, 2023 at 09:51:48AM +0800, Wenyou Yang wrote: > > Add the notifier chain to notify the cpu SMT status changes > > > > Why!?!? What's the purpose of all this? IIRC this doesn't trigger if you manually > disable all the siblings. And because you didn't tell us why you need this I can't > tell you if that matters or not :/
| |