lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 1/7] cgroup: rstat: only disable interrupts for the percpu lock
    Hello, Yosry.

    On Mon, Mar 27, 2023 at 04:23:13PM -0700, Yosry Ahmed wrote:
    > Tejun, if having the lock be non-irq is a non-starter for you, I can

    This is an actual hazard. We see in prod these unprotected locks causing
    very big spikes in tail latencies and they can be tricky to root cause too
    and given the way rstat lock is used it's highly likely to be involved in
    those scenarios with the proposed change, so it's gonna be a nack from my
    end.

    > send a patch that instead gives up the lock and reacquires it at every
    > CPU boundary unconditionally -- or perhaps every N CPU boundaries to
    > avoid excessively releasing and reacquiring the lock.

    I'd just do the simple thing and see whether there's any perf penalty before
    making it complicated. I'd be pretty surprised if unlocking and relocking
    the same spinlock adds any noticeable overhead here.

    Thanks.

    --
    tejun

    \
     
     \ /
      Last update: 2023-03-29 20:54    [W:5.181 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site