lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: selftests: net: l2tp.sh regression starting with 6.1-rc1
    On Wed, Mar 29, 2023 at 03:39:13PM +0000, Drewek, Wojciech wrote:
    >
    >
    > > -----Original Message-----
    > > -MODULE_ALIAS_NET_PF_PROTO_TYPE(PF_INET6, 2, IPPROTO_L2TP);
    > > -MODULE_ALIAS_NET_PF_PROTO(PF_INET6, IPPROTO_L2TP);
    > > +MODULE_ALIAS_NET_PF_PROTO_TYPE(PF_INET6, 2, 115 /* IPPROTO_L2TP */);
    > > +MODULE_ALIAS_NET_PF_PROTO(PF_INET6, 115 /* IPPROTO_L2TP */);
    >
    > Btw, am I blind or the alias with type was wrong the whole time?
    > pf goes first, then proto and type at the end according to the definition of MODULE_ALIAS_NET_PF_PROTO_TYPE
    > and here type (2) is 2nd and proto (115) is 3rd

    You're not blind :). The MODULE_ALIAS_NET_PF_PROTO_TYPE(...) is indeed
    wrong. Auto-loading the l2tp_ip and l2tp_ip6 modules only worked
    because of the extra MODULE_ALIAS_NET_PF_PROTO() declaration (as
    inet_create() and inet6_create() fallback to "net-pf-%d-proto-%d" if
    "net-pf-%d-proto-%d-type-%d" fails).

    \
     
     \ /
      Last update: 2023-03-29 18:54    [W:7.138 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site