Messages in this thread | | | Date | Tue, 28 Mar 2023 18:35:10 +0300 | Subject | Re: [PATCH v4 06/14] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init | From | Dmitry Baryshkov <> |
| |
On 14/03/2023 17:28, Konrad Dybcio wrote: > Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also > need REG_A6XX_GBIF_HALT to be set to 0. For GMU-equipped GPUs this is > done in a6xx_bus_clear_pending_transactions(), but for the GMU-less > ones we have to do it *somewhere*. Unhalting both side by side sounds > like a good plan and it won't cause any issues if it's unnecessary. > > Also, add a memory barrier to ensure it's gone through. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |