Messages in this thread | | | Date | Tue, 28 Mar 2023 16:00:27 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtdblock: tolerate corrected bit-flips |
| |
Hi Richard,
richard@nod.at wrote on Tue, 28 Mar 2023 15:21:50 +0200 (CEST):
> Hi! > > ----- Ursprüngliche Mail ----- > > libang.linuxer@gmail.com wrote on Thu, 23 Mar 2023 22:03:50 +0800: > > > >> mtd_read() may return -EUCLEAN in case of corrected bit-flips.This > >> particular condition should not be treated like an error. > > > > I'm fine with the patch, Richard, are you okay as well? > > Hm yes. I see the bug. I think it broke about 10 years ago > by e47f68587b82 ("mtd: check for max_bitflips in mtd_read_oob()"). > > In the early day I'd expect someone to hit this bug but I guess > on the last 10 years mtdblock had no real users.
Right.
Well, anyhow I guess this patch deserves a Fixes/Cc: stable # v3.7+
Li, can you please re-send with the proper tags? Thanks.
Thanks, Miquèl
| |