Messages in this thread | | | Date | Tue, 28 Mar 2023 15:48:58 +0300 | From | Svyatoslav Ryhel <> | Subject | Re: [PATCH v2 3/5] ARM: tegra: trans former: use labels for mmc in aliases |
| |
28 березня 2023 р. 14:39:05 GMT+03:00, Thierry Reding <thierry.reding@gmail.com> написав(-ла): >On Sat, Mar 04, 2023 at 10:43:17AM +0200, Svyatoslav Ryhel wrote: >> Since mmc devices in common dtsi are labeled let's use labels >> for simpler comprehension of tree. >> >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> >> --- >> arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi >> index 08ea9cb32d0e..70f7f279fd35 100644 >> --- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi >> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi >> @@ -12,9 +12,9 @@ / { >> chassis-type = "convertible"; >> >> aliases { >> - mmc0 = "/mmc@78000600"; /* eMMC */ >> - mmc1 = "/mmc@78000000"; /* uSD slot */ >> - mmc2 = "/mmc@78000400"; /* WiFi */ >> + mmc0 = &sdmmc4; /* eMMC */ >> + mmc1 = &sdmmc1; /* uSD slot */ >> + mmc2 = &sdmmc3; /* WiFi */ > >I find it hard to see the improvement here. If you really need this, >please merge this with the patch that adds the labels and add them on an >as-needed basis. That is, if you want to replace the paths by phandle >references here, then introduce the sdmmc{1,3,4} labels, but not the >other ones which aren't used. >
I see your point, I will reshape first 3 patches with labels. I may amend this patchset entirely, though patches 4 (mount matrix) and 5 (peripheral opps) should be valid.
Best regards, Svyatoslav R.
>Thierry
| |