lkml.org 
[lkml]   [2023]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] media: dvb-usb: dw2102: Fix uninit-value in su3000_read_mac_address
    Date
    In su3000_read_mac_address, if i2c_transfer fails to execute two
    messages, array mac address will not be initialized. Without handling
    such error, later in function dvb_usb_adapter_dvb_init, proposed_mac
    is accessed before initialization.

    Fix this error by returning a negative value if message execution fails.

    Signed-off-by: Wei Chen <harperchen1110@gmail.com>
    ---
    drivers/media/usb/dvb-usb/dw2102.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c
    index 0ca764282c76..8747960e6146 100644
    --- a/drivers/media/usb/dvb-usb/dw2102.c
    +++ b/drivers/media/usb/dvb-usb/dw2102.c
    @@ -946,7 +946,7 @@ static int su3000_read_mac_address(struct dvb_usb_device *d, u8 mac[6])
    for (i = 0; i < 6; i++) {
    obuf[1] = 0xf0 + i;
    if (i2c_transfer(&d->i2c_adap, msg, 2) != 2)
    - break;
    + return -1;
    else
    mac[i] = ibuf[0];
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-03-28 14:45    [W:4.474 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site