Messages in this thread | | | Date | Tue, 28 Mar 2023 11:53:37 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource() |
| |
Hi,
On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote: > On 28/03/2023 07:38, Yang Li wrote: > > According to commit 890cc39a8799 ("drivers: provide > > devm_platform_get_and_ioremap_resource()"), convert > > I don't understand why do you reference this commit. There is no bug > introduced there, there is nothing related to this driver. > > > platform_get_resource(), devm_ioremap_resource() to a single > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > what this function does.
I've seen Yang has sent many of these cleanups, perhaps he can write something like:
" Commit 890cc39a8799 ("drivers: provide devm_platform_get_and_ioremap_resource()") introduces the devm_platform_get_and_ioremap_resource() function which combines both platform_get_resource() and devm_ioremap_resource() into a single call.
Update the code to use the new combined function instead of the separate calls. "
With that
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks, Andi
| |