Messages in this thread Patch in this message | | | Date | Tue, 28 Mar 2023 16:55:38 -0700 | Subject | [PATCH v1 1/6] perf annotate: Delete session for debug builds | From | Ian Rogers <> |
| |
Use the debug build indicator as the guide to free the session. This implements a behavior described in a comment, which is consequentially removed.
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/builtin-annotate.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 4750fac7bf93..98d1b6379230 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c @@ -692,16 +692,12 @@ int cmd_annotate(int argc, const char **argv) out_delete: /* - * Speed up the exit process, for large files this can - * take quite a while. - * - * XXX Enable this when using valgrind or if we ever - * librarize this command. - * - * Also experiment with obstacks to see how much speed - * up we'll get here. - * - * perf_session__delete(session); + * Speed up the exit process by only deleting for debug builds. For + * large files this can save time. */ +#ifndef NDEBUG + perf_session__delete(annotate.session); +#endif + return ret; } -- 2.40.0.348.gf938b09366-goog
| |