Messages in this thread | | | Date | Tue, 28 Mar 2023 17:37:40 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v9 05/11] tracing/user_events: Add ioctl for disabling addresses |
| |
On Tue, 28 Mar 2023 17:32:00 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> > +static long user_events_ioctl_unreg(unsigned long uarg) > > +{ > > + struct user_unreg __user *ureg = (struct user_unreg __user *)uarg; > > + struct user_event_mm *mm = current->user_event_mm; > > + struct user_event_enabler *enabler, *next; > > + struct user_unreg reg; > > + long ret; > > + > > + ret = user_unreg_get(ureg, ®); > > + > > + if (ret) > > + return ret; > > + > > + if (!mm) > > + return -ENOENT; > > + > > + ret = -ENOENT; > > Probably should add: > > if (reg.__reserved || reg.__reserved2) > return -EINVAL; > > here.
I finished my review.
Can to send a v10 out with this update, and also update all the structs to have the fields tabbed out for easier reading.
Thanks!
-- Steve
| |