lkml.org 
[lkml]   [2023]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master
    On Thu, Mar 23, 2023 at 07:26:09PM +0800, Cai Huoqing wrote:
    > Remove pci_clear_master to simplify the code,
    > the bus-mastering is also cleared in do_pci_disable_device,
    > like this:
    > ./drivers/pci/pci.c:2197
    > static void do_pci_disable_device(struct pci_dev *dev)
    > {
    > u16 pci_command;
    >
    > pci_read_config_word(dev, PCI_COMMAND, &pci_command);
    > if (pci_command & PCI_COMMAND_MASTER) {
    > pci_command &= ~PCI_COMMAND_MASTER;
    > pci_write_config_word(dev, PCI_COMMAND, pci_command);
    > }
    >
    > pcibios_disable_device(dev);
    > }.
    > And dev->is_busmaster is set to 0 in pci_disable_device.
    >
    > Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>

    Reviewed-by: Simon Horman <simon.horman@corigine.com>

    \
     
     \ /
      Last update: 2023-03-27 01:17    [W:2.800 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site