Messages in this thread | | | From | Hans Schultz <> | Subject | Re: [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test | Date | Sun, 26 Mar 2023 17:41:06 +0200 |
| |
On Mon, Mar 20, 2023 at 10:44, Ido Schimmel <idosch@nvidia.com> wrote: >> + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q >> + tc_check_packets "dev $swp2 egress" 1 1 >> + check_fail $? "Dynamic FDB entry did not age out" > > Shouldn't this be check_err()? After the FDB entry was aged you want to > make sure that packets received via $swp1 with SMAC being $mac are no > longer forwarded by the bridge.
I was thinking that check_fail() will pass when tc_check_packets() does not see any packets, thus the test passing here when no packets are forwarded?
> > Also, I suggest executing 'bridge fdb get' to make sure the entry is no > longer present in the bridge FDB. >
| |