lkml.org 
[lkml]   [2023]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] media: i2c: ov7670: Use the devm_clk_get_optional() helper
    Date
    Use devm_clk_get_optional() instead of hand writing it.
    This saves some loC and improves the semantic.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    ---
    drivers/media/i2c/ov7670.c | 11 +++--------
    1 file changed, 3 insertions(+), 8 deletions(-)

    diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
    index b1bb0833571e..ecbded4f0765 100644
    --- a/drivers/media/i2c/ov7670.c
    +++ b/drivers/media/i2c/ov7670.c
    @@ -1894,14 +1894,9 @@ static int ov7670_probe(struct i2c_client *client)
    info->pclk_hb_disable = true;
    }

    - info->clk = devm_clk_get(&client->dev, "xclk"); /* optional */
    - if (IS_ERR(info->clk)) {
    - ret = PTR_ERR(info->clk);
    - if (ret == -ENOENT)
    - info->clk = NULL;
    - else
    - return ret;
    - }
    + info->clk = devm_clk_get_optional(&client->dev, "xclk");
    + if (IS_ERR(info->clk))
    + return PTR_ERR(info->clk);

    ret = ov7670_init_gpio(client, info);
    if (ret)
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-03-27 01:17    [W:4.202 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site