lkml.org 
[lkml]   [2023]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8723bs: remove unused pHalData variable
On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
> 'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
> struct hal_com_data *pHalData;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index e36f8c369a04..0cb2adcc1f78 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>
> void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
> {
> - struct hal_com_data *pHalData;
> -
> -
> - pHalData = GET_HAL_DATA(padapter);
> }

If this function doesn't do anything, does it not make more sense to
just remove this function entirely?

Best regards,
Nam

\
 
 \ /
  Last update: 2023-03-27 01:17    [W:0.055 / U:1.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site