Messages in this thread | | | Date | Sat, 25 Mar 2023 20:49:12 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH v2 2/2] media: imx: imx8mq-mipi-csi2: remove unneeded state variable and function |
| |
Hi Martin,
On Sat, Mar 25, 2023 at 10:59:47AM +0100, Martin Kepplinger wrote: > Am Sonntag, dem 12.03.2023 um 15:04 +0100 schrieb Martin Kepplinger: > > Am Sonntag, dem 12.03.2023 um 15:37 +0200 schrieb Laurent Pinchart: > > > On Tue, Mar 07, 2023 at 04:00:47PM +0100, Martin Kepplinger wrote: > > > > Clean up the driver a bit by inlining the > > > > imx8mq_mipi_csi_system_enable() > > > > function to the callsites and removing the hs_settle variable > > > > from > > > > the > > > > driver state. > > > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > > Could I volunteer you to also drop the struct csi_state state field ? > > > :-) > > > > sure :) it can become at least a bit more tricky than this patch. I'll > > take the time after this is merged. > > > > thanks for the fast reviewing > > Laurent, are these 2 patches queued up somewhere? I'm used to waiting > until they are part of a tree that is part of linux-next before sending > something new. Does that make sense?
I've just sent a pull request to Mauro for v6.4. You can find the patch in my tree at
git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git media-imx-next-20230325
-- Regards,
Laurent Pinchart
| |