lkml.org 
[lkml]   [2023]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/1] sound: soc: codecs: wcd-mbhc-v2: expose ALSA control for jack
On Sat, Mar 25, 2023 at 03:21:42PM +0100, Dylan Van Assche wrote:

>
> mutex_lock(&mbhc->lock);
>
> + ret = snd_jack_add_new_kctl(mbhc->jack->jack, "Headset Jack", WCD_MBHC_JACK_MASK);
> + if (ret)
> + dev_warn(component->dev, "failed creating Headset Jack kctl with err: %d\n", ret);
> +

No, drivers should not be open coding userspace reporting - there
is no reason for this device to be special, or for this device to
duplicate what machine drivers and the core are doing. Any
configuration should be done by the machine driver, the ASoC core
jack handling already creates userspace controls when asked.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-03-27 01:17    [W:0.040 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site