lkml.org 
[lkml]   [2023]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V4 02/10] dt-bindings: timestamp: Add Tegra234 support
    From
    On 23/03/2023 02:29, Dipen Patel wrote:
    > Added timestamp provider support for the Tegra234 in devicetree
    > bindings.
    >
    > Signed-off-by: Dipen Patel <dipenp@nvidia.com>
    > ---
    > v2:
    > - Removed nvidia,slices property
    > - Added nvidia,gpio-controller based on review comments from Thierry,
    > this will help simplify the hte provider driver.
    >
    > v3:
    > - Explained changes in detail in commit message
    > - Added allOf section per review comment
    >
    > v4:
    > - Logically divide the v3 patch as follows
    > - Created Tegra234 support patch
    > - Created depracate nvidia,slices property patch
    > - Created addition of the nvidia,gpio-controller property patch
    >
    > .../timestamp/nvidia,tegra194-hte.yaml | 44 +++++++++++++++++--
    > 1 file changed, 40 insertions(+), 4 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
    > index c31e207d1652..158dbe58c49f 100644
    > --- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
    > +++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
    > @@ -4,7 +4,7 @@
    > $id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
    > $schema: http://devicetree.org/meta-schemas/core.yaml#
    >
    > -title: Tegra194 on chip generic hardware timestamping engine (HTE)
    > +title: Tegra on chip generic hardware timestamping engine (HTE) provider
    >
    > maintainers:
    > - Dipen Patel <dipenp@nvidia.com>
    > @@ -23,6 +23,8 @@ properties:
    > enum:
    > - nvidia,tegra194-gte-aon
    > - nvidia,tegra194-gte-lic
    > + - nvidia,tegra234-gte-aon
    > + - nvidia,tegra234-gte-lic
    >
    > reg:
    > maxItems: 1
    > @@ -43,9 +45,8 @@ properties:
    > description:
    > HTE lines are arranged in 32 bit slice where each bit represents different
    > line/signal that it can enable/configure for the timestamp. It is u32
    > - property and depends on the HTE instance in the chip. The value 3 is for
    > - GPIO GTE and 11 for IRQ GTE.
    > - enum: [3, 11]
    > + property and the value depends on the HTE instance in the chip.
    > + enum: [3, 11, 17]
    >
    > '#timestamp-cells':
    > description:
    > @@ -55,6 +56,41 @@ properties:
    > mentioned in the nvidia GPIO device tree binding document.
    > const: 1
    >
    > +allOf:
    > + - if:
    > + properties:
    > + compatible:
    > + contains:
    > + enum:
    > + - nvidia,tegra194-gte-aon
    > + - nvidia,tegra234-gte-aon
    > + then:
    > + properties:
    > + nvidia,slices:
    > + const: 3
    > +
    > + - if:
    > + properties:
    > + compatible:
    > + contains:
    > + enum:
    > + - nvidia,tegra194-gte-lic
    > + then:
    > + properties:
    > + nvidia,slices:
    > + const: 11
    > +

    ... and looking at your next patch - unreviewed...

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-03-27 01:17    [W:2.461 / U:0.868 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site