Messages in this thread | | | Date | Fri, 24 Mar 2023 18:51:19 +0000 | From | Mark Brown <> | Subject | Re: [RFC 2/7] regmap: check for alignment on translated register addresses |
| |
On Fri, Mar 24, 2023 at 10:36:39AM +0100, Maxime Chevallier wrote: > With regmap->reg_base and regmap->reg_downshift, the actual register > address that is going to be used for the next operation might not be the > same as the one we have as an input. Addresses can be offset with > reg_base and shifted, which will affect alignment. > > Check for alignment on the real register address.
It is not at all clear to me that the combination of stride and downshift particularly makes sense, and especially not that the stride should be applied after downshifting rather than to what the user is passing in. [unhandled content-type:application/pgp-signature] | |