Messages in this thread | | | Date | Fri, 24 Mar 2023 08:12:28 +0100 | Subject | Re: [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes | From | Krzysztof Kozlowski <> |
| |
On 23/03/2023 14:14, Neil Armstrong wrote: > On 23/03/2023 11:51, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >>> 'pinctrl-[0-9]+' >>> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: >>> 'pinctrl-[0-9]+' >> >> I don't get from the commit msg why these properties are not correct >> here. The idle states allow them, so maybe something is missing in the >> binding? At least commit msg should explain this. > > The domain-idle-states bindings doesn't document those 2 properties, so perhaps it's missing ?
Ah, you are right. These were copied from CPU idle states, so here they do not make sense.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |