Messages in this thread | | | Date | Fri, 24 Mar 2023 14:10:13 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH v4] HID:hid-sensor-custom: Fix buffer overrun in device name |
| |
On Tue, 14 Mar 2023, Todd Brandt wrote:
> On some platforms there are some platform devices created with > invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead > of "HID-SENSOR-INT-020b.39.auto" > > This string include some invalid characters, hence it will fail to > properly load the driver which will handle this custom sensor. Also > it is a problem for some user space tools, which parses the device > names from ftrace and dmesg. > > This is because the string, real_usage, is not NULL terminated and > printed with %s to form device name. > > To address this, initialize the real_usage string with 0s. > > Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217169 > Fixes: 98c062e82451 ("HID: hid-sensor-custom: Allow more custom iio sensors") > Cc: stable@vger.kernel.org > Suggested-by: Philipp Jungkamp <p.jungkamp@gmx.net> > Signed-off-by: Philipp Jungkamp <p.jungkamp@gmx.net> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com> > Reviewed-by: Andi Shyti <andi.shyti@kernel.org> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > Changes in v4: > - add the Fixes line > - add patch version change list > Changes in v3: > - update the changelog > - add proper reviewed/signed/suggested links > Changes in v2: > - update the changelog
Applied to for-6.3/upstream-fixes, thanks.
-- Jiri Kosina SUSE Labs
| |