Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Fri, 24 Mar 2023 12:55:20 +0100 | Subject | Re: [PATCH v1 2/2] ACPI: SPCR: Amend indentation |
| |
On Fri, Mar 24, 2023 at 10:05 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Mar 23, 2023 at 09:31:11PM +0100, Rafael J. Wysocki wrote: > > On Thu, Mar 23, 2023 at 1:24 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Wed, Mar 22, 2023 at 07:50:55PM +0100, Rafael J. Wysocki wrote: > > > > On Wed, Mar 22, 2023 at 11:26 AM Andy Shevchenko > > > > <andriy.shevchenko@linux.intel.com> wrote: > > ... > > > > > > 2) Remove double spaces for consistency. > > > > > > > > I don't quite agree with this. > > > > > > > > Double spaces after a period are recognized as end-of-sentence markers > > > > by some editors (notably vi), so if they have been used intentionally, > > > > I see no reason to replace them. > > > > > > For the sake of consistency. There places in very same file which do not > > > follow this. I can invert and add a space to the rest. Do you prefer that? > > > > Not really. I just don't think that this is worth the churn. > > Ah, that's fine. > > > > The reasoning will be kept the same, though. > > > > Is the lack of consistency in this particular respect really an issue? > > > > I guess you can argue that if there are mixed sentence ending styles > > in one and the same comment, it is better to make them consistent, > > which I can agree with. Otherwise I'm not convinced. > > Okay, do you agree with the first patch in the series?
I do. In fact, I've applied it already.
> Then I can redo this one by dropping these particular > changes.
Yes, please.
| |