Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Fri, 24 Mar 2023 11:51:41 +0000 | Subject | Re: [PATCH] dt-bindings: timer: renesas: ostm: Document RZ/Five SoC |
| |
Hi Geert,
Thank you for the review.
On Fri, Mar 24, 2023 at 9:35 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > Thanks for your patch! > > On Thu, Mar 23, 2023 at 7:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > The OSTM block on the RZ/Five SoC is identical to one found on the RZ/G2UL > > SoC. "renesas,r9a07g043-ostm" compatible string will be used on the > > RZ/Five SoC so to make this clear, update the comment to include RZ/Five > > SoC. > > > > No driver changes are required as generic compatible string > > "renesas,ostm" will be used as a fallback on RZ/Five SoC. > > While this paragraph is true, it doesn't really matter, as you're not > adding a new SoC-specific compatible value. > Agreed, I will keep that in mind for future patches.
Cheers, Prabhakar
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > > +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml > > @@ -23,7 +23,7 @@ properties: > > - enum: > > - renesas,r7s72100-ostm # RZ/A1H > > - renesas,r7s9210-ostm # RZ/A2M > > - - renesas,r9a07g043-ostm # RZ/G2UL > > + - renesas,r9a07g043-ostm # RZ/G2UL and RZ/Five > > - renesas,r9a07g044-ostm # RZ/G2{L,LC} > > - renesas,r9a07g054-ostm # RZ/V2L > > - const: renesas,ostm # Generic > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |