Messages in this thread | | | Date | Fri, 24 Mar 2023 13:50:07 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/3] counter: 104-quad-8: Refactor to buffer states for CMR, IOR, and IDR |
| |
On Fri, Mar 24, 2023 at 01:48:43PM +0200, Andy Shevchenko wrote: > On Thu, Mar 23, 2023 at 05:25:28PM -0400, William Breathitt Gray wrote:
...
> > +static void quad8_control_register_update(struct quad8 *const priv, u8 *const buf, > > + const size_t channel, const u8 val, const u8 field) > > +{ > > + u8p_replace_bits(&buf[channel], val, field); > > + iowrite8(buf[channel], &priv->reg->channel[channel].control); > > +} > > How did you compile this? > Due to nature of *_replace_bits() this may only be a macro. > > That's what LKP is telling about I think.
Ah, no, that's because the last parameter is not constant in the last patch in the series.
-- With Best Regards, Andy Shevchenko
| |