Messages in this thread | | | Date | Fri, 24 Mar 2023 11:11:41 +0100 | Subject | Re: [PATCH] thermal: amlogic: Use dev_err_probe() | From | Neil Armstrong <> |
| |
On 24/03/2023 03:20, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen <ye.xingchen@zte.com.cn> > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn> > --- > drivers/thermal/amlogic_thermal.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c > index 4bf36386462f..3abc2dcef408 100644 > --- a/drivers/thermal/amlogic_thermal.c > +++ b/drivers/thermal/amlogic_thermal.c > @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev) > return PTR_ERR(pdata->regmap); > > pdata->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(pdata->clk)) { > - if (PTR_ERR(pdata->clk) != -EPROBE_DEFER) > - dev_err(dev, "failed to get clock\n"); > - return PTR_ERR(pdata->clk); > - } > + if (IS_ERR(pdata->clk)) > + return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n"); > > pdata->sec_ao_map = syscon_regmap_lookup_by_phandle > (pdev->dev.of_node, "amlogic,ao-secure");
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
| |