Messages in this thread | | | Date | Fri, 24 Mar 2023 10:40:20 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH 1/2] dt-bindings: mtd: nand: Macronix: document new binding |
| |
Hi Álvaro,
noltari@gmail.com wrote on Thu, 23 Mar 2023 13:45:09 +0100:
> Add new "mxic,disable-block-protection" binding documentation. > This binding allows disabling block protection support for those devices not > supporting it. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > Documentation/devicetree/bindings/mtd/nand-macronix.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/nand-macronix.txt b/Documentation/devicetree/bindings/mtd/nand-macronix.txt > index ffab28a2c4d1..03f65ca32cd3 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-macronix.txt > +++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt > @@ -16,6 +16,9 @@ in children nodes. > Required NAND chip properties in children mode: > - randomizer enable: should be "mxic,enable-randomizer-otp" > > +Optional NAND chip properties in children mode: > +- block protection disable: should be "mxic,disable-block-protection" > +
Besides the fact that nowadays we prefer to see binding conversions to yaml before adding anything, I don't think this will fly.
I'm not sure exactly what "disable block protection" means, we already have similar properties like "lock" and "secure-regions", not sure they will fit but I think it's worth checking.
Otherwise, why would you disable the block protection? What does it mean exactly? I'm not in favor of a Macronix-specific property here.
Thanks, Miquèl
| |