Messages in this thread | | | Subject | Re: [PATCH net v2] net: dsa: realtek: fix out-of-bounds access | From | patchwork-bot+netdevbpf@kernel ... | Date | Sat, 25 Mar 2023 02:10:17 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Thu, 23 Mar 2023 11:37:35 +0100 you wrote: > The probe function sets priv->chip_data to (void *)priv + sizeof(*priv) > with the expectation that priv has enough trailing space. > > However, only realtek-smi actually allocated this chip_data space. > Do likewise in realtek-mdio to fix out-of-bounds accesses. > > These accesses likely went unnoticed so far, because of an (unused) > buf[4096] member in struct realtek_priv, which caused kmalloc to > round up the allocated buffer to a big enough size, so nothing of > value was overwritten. With a different allocator (like in the barebox > bootloader port of the driver) or with KASAN, the memory corruption > becomes quickly apparent. > > [...]
Here is the summary with links: - [net,v2] net: dsa: realtek: fix out-of-bounds access https://git.kernel.org/netdev/net/c/b93eb5648693
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |