Messages in this thread | | | Date | Fri, 24 Mar 2023 22:44:02 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol |
| |
Hi Radhey,
Thank you for the patch.
On Fri, Mar 24, 2023 at 05:54:39PM +0530, Radhey Shyam Pandey wrote: > SGMII is validated on kria KR260 robotics starter kit. So modify the > comment description to include it in supported controllers list. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> > --- > drivers/phy/xilinx/phy-zynqmp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c > index 9be9535ad7ab..ebe5ba730234 100644 > --- a/drivers/phy/xilinx/phy-zynqmp.c > +++ b/drivers/phy/xilinx/phy-zynqmp.c > @@ -8,9 +8,9 @@ > * Author: Subbaraya Sundeep <sundeep.lkml@gmail.com> > * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > * > - * This driver is tested for USB, SATA and Display Port currently. > - * Other controllers PCIe and SGMII should also work but that is > - * experimental as of now. > + * This driver is tested for USB, SGMII, SATA and Display Port currently. > + * Other controller i.e PCIe should also work but that is experimental
As only PCIe is left, I'd write
* PCIe should also work but that is experimental as of now.
With that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Of course it would be even better if you could test PCIe ;-)
> + * as of now. > */ > > #include <linux/clk.h>
-- Regards,
Laurent Pinchart
| |