Messages in this thread | | | Date | Thu, 23 Mar 2023 17:16:59 +0100 | Subject | Re: [RFC v2 0/5] remove page_endio() | From | Pankaj Raghav <> |
| |
>> I also changed mpage to **not set** the error flag in the read path. It does beg >> the question whether block_read_full_folio() and iomap_finish_folio_read() should >> also follow the suit. > > Wrong. mpage is used by filesystems which *DO* check the error flag. > You can't remove it being set until they're fixed to not check it. Got it. I think after your explanation on the Error flag, it makes sense why mpage needs to set the error flag, for now. I will change it as a part of the next version along with the other comment on Patch 4.
| |