Messages in this thread | | | Date | Thu, 23 Mar 2023 17:08:47 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() |
| |
On Thu, Mar 23, 2023 at 10:02:38AM -0500, Bjorn Helgaas wrote: > On Thu, Mar 23, 2023 at 04:30:01PM +0200, Andy Shevchenko wrote:
...
> I poked around looking for similar patterns elsewhere with: > > git grep "#define.*for_each_.*_p(" > git grep "#define.*for_each_.*_idx(" > > I didn't find any other "_p" iterators and just a few "_idx" ones, so > my hope is to follow what little precedent there is, as well as > converge on the basic "*_for_each_resource()" iterators and remove the > "_idx()" versions over time by doing things like the > pci_claim_resource() change.
The p is heavily used in the byte order conversion helpers.
> What do you think? If it seems like excessive churn, we can do it > as-is and still try to reduce the use of the index variable over time.
I think _p has a precedent as well. But I can think about it a bit, maybe we can come up with something smarter.
-- With Best Regards, Andy Shevchenko
| |