Messages in this thread | | | Date | Thu, 23 Mar 2023 13:59:21 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 2/2] spi: loongson: add bus driver for the loongson spi controller |
| |
On Thu, Mar 23, 2023 at 08:46:19PM +0800, zhuyinbo wrote:
> I think add following change and that issue what you said will can be > fixed, in addition, the spin_lock
> was also not needed. Do you think so?
> @@ -101,8 +101,10 @@ static int loongson_spi_setup(struct spi_device *spi) > if (spi->chip_select >= spi->master->num_chipselect) > return -EINVAL; > > + loongson_spi->hz = 0; > + loongson_spi->mode &= SPI_NO_CS; > + > spin_lock(&loongson_spi->lock); > - loongson_spi_update_state(loongson_spi, spi, NULL);
Looks plausible, yes - I'd need to see the full thing to verify. [unhandled content-type:application/pgp-signature] | |