Messages in this thread | | | Date | Thu, 23 Mar 2023 12:50:49 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH 1/1] vhost_task: Fix vhost_task_create return value |
| |
On Thu, Mar 23, 2023 at 07:43:04AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 23, 2023 at 11:44:45AM +0100, Christian Brauner wrote: > > On Thu, Mar 23, 2023 at 03:37:19AM -0400, Michael S. Tsirkin wrote: > > > On Wed, Mar 22, 2023 at 01:56:05PM -0500, Mike Christie wrote: > > > > vhost_task_create is supposed to return the vhost_task or NULL on > > > > failure. This fixes it to return the correct value when the allocation > > > > of the struct fails. > > > > > > > > Fixes: 77feab3c4156 ("vhost_task: Allow vhost layer to use copy_process") # mainline only > > > > Reported-by: syzbot+6b27b2d2aba1c80cc13b@syzkaller.appspotmail.com > > > > Signed-off-by: Mike Christie <michael.christie@oracle.com> > > > > > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > > > > > The affected patch is not upstream yet, right? > > > I don't know if the tree in question allows rebases - linux-next > > > does. So ideally it would be squashed to avoid issues during bisect. > > > Still it's error path so I guess not a tragedy even without squashing. > > > > I tend to not rebase once stuff has been in linux-next but I make > > exceptions as long as it's before -rc4. For now I've put the patch on > > top (see the other mail I sent) but if it's really important I can > > squash it after the weekend (I'll be mostly afk until then.). > > Hard to say how important, but I'd prefer that, yes.
Ok, fold the fixup into
e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process
the series is now at:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git branch: kernel.user_worker
1a5f8090c6de vhost: move worker thread fields to new struct e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process 89c8e98d8cfb fork: allow kernel code to call copy_process 094717586bf7 fork: Add kernel_clone_args flag to ignore signals 11f3f500ec8a fork: add kernel_clone_args flag to not dup/clone files 54e6842d0775 fork/vm: Move common PF_IO_WORKER behavior to new flag c81cc5819faf kernel: Make io_thread and kthread bit fields 73e0c116594d kthread: Pass in the thread's name during creation cf587db2ee02 kernel: Allow a kernel thread's name to be set in copy_process e0a98139c162 csky: Remove kernel_thread declaration
| |