lkml.org 
[lkml]   [2023]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: vme_user: Fixing coding style issues reported by checkpatch
On Wed, Mar 22, 2023 at 07:59:23PM +0530, Rohit Chavan wrote:
> Fixing alignment should match open parenthesis issue on multiple lines,
> reported by checkpatch script.

You might want to mention on the subject line that this is a parenthesis
issue, right?

> Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
> ---
> drivers/staging/vme_user/vme_tsi148.c | 102 +++++++++++++-------------
> 1 file changed, 51 insertions(+), 51 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
> index 2f5eafd50934..716de1d7fe21 100644
> --- a/drivers/staging/vme_user/vme_tsi148.c
> +++ b/drivers/staging/vme_user/vme_tsi148.c
> @@ -55,14 +55,14 @@ static struct pci_driver tsi148_driver = {
> };
>
> static void reg_join(unsigned int high, unsigned int low,
> - unsigned long long *variable)
> + unsigned long long *variable)

For many of these, you can just move the line to the previous one,
making it a single line, right? That would make the code much more
readable.

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-03-27 01:13    [W:0.029 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site