Messages in this thread | | | Date | Thu, 23 Mar 2023 15:26:07 -0700 | Subject | Re: [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging | From | Sathyanarayanan Kuppuswamy <> |
| |
On 3/23/23 3:20 PM, Terry Bowman wrote: > Adding PCI reviewers. > > https://lore.kernel.org/all/20230323213808.398039-1-terry.bowman@amd.com/
> > On 3/23/23 16:38, Terry Bowman wrote: >> The CXL driver plans to use cper_print_aer() for restricted CXL host >> (RCH) logging. cper_print_aer() is not exported and as a result is not >> available to the CXL driver or other loadable modules. Export >> cper_print_aer() making it available to CXL and other loadable modules. >> >> Signed-off-by: Terry Bowman <terry.bowman@amd.com> >> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> >> Cc: "Oliver O'Halloran" <oohall@gmail.com> >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> Cc: linux-pci@vger.kernel.org >> ---
Looks fine to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> drivers/pci/pcie/aer.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c >> index 625f7b2cafe4..7f0f52d094a4 100644 >> --- a/drivers/pci/pcie/aer.c >> +++ b/drivers/pci/pcie/aer.c >> @@ -809,6 +809,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, >> trace_aer_event(dev_name(&dev->dev), (status & ~mask), >> aer_severity, tlp_header_valid, &aer->header_log); >> } >> +EXPORT_SYMBOL_GPL(cper_print_aer); >> #endif >> >> /**
-- Sathyanarayanan Kuppuswamy Linux Kernel Developer
| |