Messages in this thread | | | Date | Thu, 23 Mar 2023 14:14:19 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v7 6/9] clk: hisilicon: Convert to platform_driver |
| |
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 6015b1aca1a233379625385feb01dd014aca60b5]
url: https://github.com/intel-lab-lkp/linux/commits/David-Yang/clk-hisilicon-Rename-Hi3798CV200-to-Hi3798/20230323-004453 base: 6015b1aca1a233379625385feb01dd014aca60b5 patch link: https://lore.kernel.org/r/20230322164201.2454771-7-mmyangfl%40gmail.com patch subject: [PATCH v7 6/9] clk: hisilicon: Convert to platform_driver config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230323/202303231426.GOJVQoEn-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f551034776d2c5eb0495634bd2f8bde5c4743f92 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Yang/clk-hisilicon-Rename-Hi3798CV200-to-Hi3798/20230323-004453 git checkout f551034776d2c5eb0495634bd2f8bde5c4743f92 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/clk/hisilicon/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303231426.GOJVQoEn-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/clk/hisilicon/clk-hix5hd2.c: In function 'hix5hd2_clk_register_complex': >> drivers/clk/hisilicon/clk-hix5hd2.c:260:46: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 260 | struct hix5hd2_complex_clock *clks = clocks; | ^~~~~~
vim +/const +260 drivers/clk/hisilicon/clk-hix5hd2.c
255 256 static int 257 hix5hd2_clk_register_complex(struct device *dev, const void *clocks, int nums, 258 struct hisi_clock_data *data) 259 { > 260 struct hix5hd2_complex_clock *clks = clocks; 261 void __iomem *base = data->base; 262 int i; 263 264 for (i = 0; i < nums; i++) { 265 struct hix5hd2_clk_complex *p_clk; 266 struct clk *clk; 267 struct clk_init_data init; 268 269 p_clk = kzalloc(sizeof(*p_clk), GFP_KERNEL); 270 if (!p_clk) 271 return -ENOMEM; 272 273 init.name = clks[i].name; 274 if (clks[i].type == TYPE_ETHER) 275 init.ops = &clk_ether_ops; 276 else 277 init.ops = &clk_complex_ops; 278 279 init.flags = 0; 280 init.parent_names = 281 (clks[i].parent_name ? &clks[i].parent_name : NULL); 282 init.num_parents = (clks[i].parent_name ? 1 : 0); 283 284 p_clk->ctrl_reg = base + clks[i].ctrl_reg; 285 p_clk->ctrl_clk_mask = clks[i].ctrl_clk_mask; 286 p_clk->ctrl_rst_mask = clks[i].ctrl_rst_mask; 287 p_clk->phy_reg = base + clks[i].phy_reg; 288 p_clk->phy_clk_mask = clks[i].phy_clk_mask; 289 p_clk->phy_rst_mask = clks[i].phy_rst_mask; 290 p_clk->hw.init = &init; 291 292 clk = clk_register(NULL, &p_clk->hw); 293 if (IS_ERR(clk)) { 294 kfree(p_clk); 295 pr_err("%s: failed to register clock %s\n", 296 __func__, clks[i].name); 297 return PTR_ERR(p_clk); 298 } 299 300 data->clk_data.clks[clks[i].id] = clk; 301 } 302 303 return 0; 304 } 305
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |