Messages in this thread | | | Date | Thu, 23 Mar 2023 19:37:50 +0100 | From | Simon Horman <> | Subject | Re: [PATCH] mISDN: remove unused vpm_read_address and cpld_read_reg functions |
| |
On Thu, Mar 23, 2023 at 12:13:43PM -0400, Tom Rix wrote: > clang with W=1 reports > drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function > 'vpm_read_address' [-Werror,-Wunused-function] > vpm_read_address(struct hfc_multi *c) > ^ > > drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function > 'cpld_read_reg' [-Werror,-Wunused-function] > cpld_read_reg(struct hfc_multi *hc, unsigned char reg) > ^ > > These functions are not used, so remove them. > > Reported-by: Simon Horman <simon.horman@corigine.com>
FWIIW, says this should go here.
Link: https://lore.kernel.org/netdev/ZBsArtzFkgz+05LK@corigine.com/
> Signed-off-by: Tom Rix <trix@redhat.com>
Patch looks good, thanks.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
| |