lkml.org 
[lkml]   [2023]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] cpufreq: schedutil: Refactor sugov_update_shared() internals
    Date
    Remove the if section block. Use the simple check to bail out
    and jump to the unlock at the end. That makes the code more readable
    and ready for some future tracing.

    Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
    ---
    kernel/sched/cpufreq_schedutil.c | 20 +++++++++++---------
    1 file changed, 11 insertions(+), 9 deletions(-)

    diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
    index e3211455b203..f462496e5c07 100644
    --- a/kernel/sched/cpufreq_schedutil.c
    +++ b/kernel/sched/cpufreq_schedutil.c
    @@ -446,17 +446,19 @@ sugov_update_shared(struct update_util_data *hook, u64 time, unsigned int flags)

    ignore_dl_rate_limit(sg_cpu);

    - if (sugov_should_update_freq(sg_policy, time)) {
    - next_f = sugov_next_freq_shared(sg_cpu, time);
    + if (!sugov_should_update_freq(sg_policy, time))
    + goto unlock;

    - if (!sugov_update_next_freq(sg_policy, time, next_f))
    - goto unlock;
    + next_f = sugov_next_freq_shared(sg_cpu, time);
    +
    + if (!sugov_update_next_freq(sg_policy, time, next_f))
    + goto unlock;
    +
    + if (sg_policy->policy->fast_switch_enabled)
    + cpufreq_driver_fast_switch(sg_policy->policy, next_f);
    + else
    + sugov_deferred_update(sg_policy);

    - if (sg_policy->policy->fast_switch_enabled)
    - cpufreq_driver_fast_switch(sg_policy->policy, next_f);
    - else
    - sugov_deferred_update(sg_policy);
    - }
    unlock:
    raw_spin_unlock(&sg_policy->update_lock);
    }
    --
    2.17.1
    \
     
     \ /
      Last update: 2023-03-27 01:12    [W:3.770 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site