Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Andy Shevchenko <> | Subject | [PATCH v1 11/14] extcon: Remove dup device name in the message and unneeded error check | Date | Wed, 22 Mar 2023 16:40:02 +0200 |
| |
The device name is already printed with dev_err(), no need to repeat. The device pointer itself is not supposed to be an error point, drop that check.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/extcon/extcon.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 32e96cb49067..0e04ea185c26 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1367,9 +1367,8 @@ void extcon_dev_unregister(struct extcon_dev *edev) list_del(&edev->entry); mutex_unlock(&extcon_dev_list_lock); - if (IS_ERR_OR_NULL(get_device(&edev->dev))) { - dev_err(&edev->dev, "Failed to unregister extcon_dev (%s)\n", - dev_name(&edev->dev)); + if (!get_device(&edev->dev)) { + dev_err(&edev->dev, "Failed to unregister extcon_dev\n"); return; } -- 2.40.0.1.gaa8946217a0b
| ![\](/images/icornerr.gif) |