Messages in this thread | | | From | Alvin Šipraga <> | Subject | Re: [PATCH] extcon: usbc-tusb320: add USB_ROLE_SWITCH dependency | Date | Wed, 22 Mar 2023 13:05:36 +0000 |
| |
On Wed, Mar 22, 2023 at 12:16:51PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When CONFIG_USB_ROLE_SWITCH=m, tusb320 cannot be built-in: > > ld.lld: error: undefined symbol: fwnode_usb_role_switch_get > >>> referenced by extcon-usbc-tusb320.c > >>> drivers/extcon/extcon-usbc-tusb320.o:(tusb320_probe) in archive vmlinux.a > ld.lld: error: undefined symbol: usb_role_switch_set_role > >>> referenced by extcon-usbc-tusb320.c > >>> drivers/extcon/extcon-usbc-tusb320.o:(tusb320_state_update_handler) in archive vmlinux.a > > Add the appropriate Kconfig dependency to prevent this > configuration but still allow the driver to be built-in > when USB_ROLE_SWITCH is disabled. > > Fixes: 19685ae43489 ("extcon: usbc-tusb320: add usb_role_switch support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
I overlooked this possibility, my bad... Thanks Arnd for fixing!
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> | |