Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 21 Mar 2023 21:41:24 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net: phy: Improved phy_error() with function and error code |
| |
On Mon, 20 Mar 2023 14:34:51 -0700 Florian Fainelli wrote: > +static inline void phy_error(struct phy_device *phydev) > +{ > + phy_error_precise(phydev, (const void *)_RET_IP_, -EIO); > +}
LGTM apart from this _RET_IP_ here. Wouldn't this make @func sometimes the function that returned the error and sometimes the caller? The caller is in the stack trace already, so no need to duplicate. Besides how dependable is using _RET_IP_ inside a static inline?
| ![\](/images/icornerr.gif) |