Messages in this thread | | | Date | Wed, 22 Mar 2023 09:17:58 +0100 | Subject | Re: [PATCH v3 1/4] mm/mmap/vma_merge: further improve prev/next VMA naming | From | Vlastimil Babka <> |
| |
On 3/22/23 08:13, Lorenzo Stoakes wrote: > Previously the ASCII diagram above vma_merge() and the accompanying > variable naming was rather confusing, however recent efforts by Liam > Howlett and Vlastimil Babka have significantly improved matters. > > This patch goes a little further - replacing 'X' with 'N', which feels more > natural as this represents the _next_ VMA and replacing what was 'N' with > 'C' which represents the current VMA.
Might have wanted to mention the 'A' to '*' change as well?
> No word quite describes a VMA that has coincident start as the input span, > however 'concurrent' (or more simply 'current') abbreviated to 'curr' fits > intuitions well alongside prev and next.
'curr' sounds good to me, I concur
> This has no functional impact. > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> --- > mm/mmap.c | 86 +++++++++++++++++++++++++++---------------------------- > 1 file changed, 43 insertions(+), 43 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 042d22e63528..c9834364ac98 100644
| |