Messages in this thread | | | Date | Wed, 22 Mar 2023 08:36:10 +0100 | Subject | Re: [PATCH v3 2/3] media: dt-bindings: ov2685: convert to dtschema | From | Krzysztof Kozlowski <> |
| |
On 21/03/2023 19:03, Luca Weiss wrote: > Convert the text-based dt-bindings to yaml. >
Thank you for your patch. There is something to discuss/improve.
> + - Shunqian Zheng <zhengsq@rock-chips.com> > + > +properties: > + compatible: > + const: ovti,ov2685 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: XVCLK clock > + > + clock-names: > + items: > + - const: xvclk > + > + dvdd-supply: > + description: Digital Domain Power Supply > + > + avdd-supply: > + description: Analog Domain Power Supply > + > + dovdd-supply: > + description: I/O Domain Power Supply > + > + reset-gpios: > + maxItems: 1 > + description: Reset Pin GPIO Control (active low) > + > + port: > + description: MIPI CSI-2 transmitter port > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + maxItems: 1 > + > + required: > + - data-lanes > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - dvdd-supply > + - avdd-supply > + - dovdd-supply > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/rk3399-cru.h> > + #include <dt-bindings/gpio/gpio.h> > + > + i2c7 {
i2c
With above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |