Messages in this thread | | | From | Frank Li <> | Subject | RE: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings | Date | Wed, 22 Mar 2023 21:36:48 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, March 22, 2023 4:32 PM > To: Frank Li <frank.li@nxp.com> > Cc: devicetree@vger.kernel.org; festevam@gmail.com; imx@lists.linux.dev; > kernel@pengutronix.de; krzysztof.kozlowski+dt@linaro.org; linux-arm- > kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>; linux- > kernel@vger.kernel.org; robh+dt@kernel.org; s.hauer@pengutronix.de; > shawnguo@kernel.org > Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add > imx8qm cdns3 glue bindings > > Caution: EXT Email > > On 22/03/2023 15:34, Frank Li wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: Wednesday, March 22, 2023 2:32 AM > >> To: Frank Li <frank.li@nxp. > >>> + - const: usb3_aclk > >>> + - const: usb3_ipg_clk > >>> + - const: usb3_core_pclk > >>> + > >>> + assigned-clocks: > >>> + items: > >>> + - description: Phandle and clock specifoer of > >> IMX_SC_PM_CLK_MST_BUS. > >> > >> Drop useless pieces so "Phandle and clock specifoer of " and name the > >> hardware, not the syntax. > >> > >>> + > >>> + assigned-clock-rates: > >>> + items: > >>> + - description: Should be in Range 100 - 600 Mhz. > >> > >> That's better but I still do not understand why do you need it in the > >> bindings. You never actually answered this question. > > > > I am not sure 100% sure the reason. > > I think difference system target's axi bus frequency is difference, > > And just one time work, needn't software to manage it. > > Following other driver's code style may be another reason. > > That's the reason of heaving it in DTS. But I am asking about bindings. > You do understand you define here interface?
I defined here is descript AXI frequency for usb controller. Supposed difference Platform will have difference working frequency.
> > Best regards, > Krzysztof
| |