lkml.org 
[lkml]   [2023]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 9/9] fbdev: au1200fb: Fix potential divide by zero
    Date
    From: Wei Chen <harperchen1110@gmail.com>

    [ Upstream commit 44a3b36b42acfc433aaaf526191dd12fbb919fdb ]

    var->pixclock can be assigned to zero by user. Without
    proper check, divide by zero would occur when invoking
    macro PICOS2KHZ in au1200fb_fb_check_var.

    Error out if var->pixclock is zero.

    Signed-off-by: Wei Chen <harperchen1110@gmail.com>
    Signed-off-by: Helge Deller <deller@gmx.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/au1200fb.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c
    index 6c542d0ca076e..e17a083f849ad 100644
    --- a/drivers/video/fbdev/au1200fb.c
    +++ b/drivers/video/fbdev/au1200fb.c
    @@ -1039,6 +1039,9 @@ static int au1200fb_fb_check_var(struct fb_var_screeninfo *var,
    u32 pixclock;
    int screen_size, plane;

    + if (!var->pixclock)
    + return -EINVAL;
    +
    plane = fbdev->plane;

    /* Make sure that the mode respect all LCD controller and
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-03-27 01:13    [W:2.595 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site