lkml.org 
[lkml]   [2023]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: most: fix line ending with '('
On Wed, Mar 22, 2023 at 06:09:50PM +0300, Dan Carpenter wrote:
> On Wed, Mar 22, 2023 at 08:01:52PM +0500, Khadija Kamran wrote:
> > Splitting function header to multiple lines because of 80 characters per
> > line limit, results in ending the function call line with '('.
> > This leads to CHECK reported by checkpatch.pl
> >
> > Move the function parameters right after the '(' in the function call
> > line. Align the rest of the parameters to the opening parenthesis.
> >
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
> >
> > Changes in v2:
> > - Changed the description
> >
>
> No one replied to the v1 of this patch so it's not clear which of the
> patches should be ignored.
>

Hey Dan!

I created a patch revision without any feedback. My bad. I thought the
description in the previous patch was misleading, so I wanted to change
it.

> Also you have a couple patches with the same subject and that's against
> the rules.
>

I am sorry about that. Kindly guide me here.
Both patches are for same driver i.e. staging/most, but for different
files. Would it be fine to add file names in the subject to
differentiate them?

Regards,
Khadija

> regards,
> dan carpenter
>

\
 
 \ /
  Last update: 2023-03-27 01:12    [W:0.036 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site